[openstreetmap/openstreetmap-website] Add moderation zones where anonymous notes are not allowed (PR #6713)
Andy Allan
notifications at github.com
Wed Apr 29 15:56:15 UTC 2026
@gravitystorm approved this pull request.
I don't have any blockers, I'm happy to merge this unless someone else spots something.
Minor comment about package names inline.
> @@ -157,6 +161,10 @@ jobs:
cache: yarn
- name: Install node modules
run: bundle exec bin/yarn install
+ - name: Install packages
+ run: |
+ sudo apt-get -yqq update
+ sudo apt-get -yqq install postgis
I want to just quibble slightly over the package that we want to install:
* `postgis` - this only contains client-side stuff, i.e. "PostGIS userland binaries for importing and
exporting shape and raster files: pgsql2shp, raster2pgsql, and shp2pgsql." We don't need these. However, it also "recommends" the metapackage `postgresql-postgis`, which is more useful...
* `postgresql-postgis` is a metapackage that points at whichever `postgresql-X-postgis-Y` is default on the distribution
* `postgresql-X-postgis-Y` contains the actual server-side extension (and depends on some other minor packages).
In some places we're installing `postgis` but relying on (hoping?) the "recommends" packages get installed too. In other places we're installing the `postgresql-X-postgis-Y` package explicitly, but that will need to kept in sync whenever the underlying distro/image is updated.
Is it preferable to standardise on the `postgresql-postgis` package throughout?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6713#pullrequestreview-4198594950
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6713/review/4198594950 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260429/37f531a4/attachment.htm>
More information about the rails-dev
mailing list