[openstreetmap/openstreetmap-website] Add Herb parser and linter (PR #6784)

[Tom Hughes]

@tomhughes commented on this pull request.

How does this overlap with what `erb_lint` is already doing?

> @@ -40,6 +40,31 @@ jobs:
         bundler-cache: true
     - name: Run erblint
       run: bundle exec erb_lint .
+  herb:
+    name: Herb
+    runs-on: ubuntu-latest

I was going to say why `latest` when the others use `22.04` but I see rubocop also uses `latest` so it seems we're already inconsistent...

> @@ -40,6 +40,31 @@ jobs:
         bundler-cache: true
     - name: Run erblint
       run: bundle exec erb_lint .
+  herb:
+    name: Herb
+    runs-on: ubuntu-latest
+    timeout-minutes: 10
+    steps:
+    - name: Check out code
+      uses: actions/checkout at de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+    - name: Setup ruby
+      uses: ruby/setup-ruby at 90be1154f987f4dc0fe0dd0feedac9e473aa4ba8 # v1.286.0

That seems to be an older version than other linters in here are using?

> +      with:
+        ruby-version: ${{ env.ruby }}
+        rubygems: 3.4.10
+        bundler-cache: true
+    - name: Run herb parser
+      run: bundle exec herb analyze app/ --no-log-file --non-interactive
+    - name: Cache node modules
+      uses: actions/setup-node at 6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
+      with:
+        cache: yarn
+    - name: Install node modules
+      run: bundle exec bin/yarn install
+    - name: Create dummy database configuration
+      run: cp config/example.database.yml config/database.yml
+    - name: Run herb linter
+      run: yarn herb-lint

Maybe make this consistent with how we run installs? Also I think using `yarn run` is better than relying on yarn treating unknown commands as scripts to run...

```suggestion
      run: bundle exec bin/yarn run herb-lint
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6784#pullrequestreview-3769883531
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6784/review/3769883531 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260208/b1791843/attachment.htm>