[openstreetmap/openstreetmap-website] Maplibre embeds from leaflet to maplibre (PR #6804)

[Frank Elsinga]

@CommanderStorm commented on this pull request.



> +  const attribution = new OSM.MapLibre.AttributionControl({
+    credit: layerConfig.credit,
+    includeReportLink: true
+  });
+  map.addControl(attribution, 'bottom-right');
 
-  _update: function () {
-    L.Control.Attribution.prototype._update.call(this);
+  const position = document.documentElement.dir === "rtl" ? "top-left" : "top-right";
+  const navigationControl = new OSM.MapLibre.NavigationControl();
+  map.addControl(new OSM.MapLibre.CombinedControlGroup([navigationControl]), position);

Is this RTL handling correct? (previously there was no RTL handling)
- attribution always on the right
- navigation on right for ltr and left for rtl

I am not an RTL expert, since germany is firmly LTR

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6804#pullrequestreview-3788564977
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6804/review/3788564977 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260211/d35019f5/attachment-0001.htm>