[openstreetmap/openstreetmap-website] Tags editor (PR #6758)

Pablo Brasero notifications at github.com
Mon Feb 16 15:19:39 UTC 2026


pablobm left a comment (openstreetmap/openstreetmap-website#6758)

Thank you @simonpoole, that was illuminating.

So any editor, including this one, is responsible for validation. The API won't do it as it can't be an arbiter of the evolving conventions and schemas in the community. This leads to complications even in cases like this one, as certain tags can have complex effects.

Now, as for this PR, I see the following:
1. Explicit validation of the format of any new keys introduced in the object.
	- Is this established enough a convention that could be implemented in the backend?
	- In particular I wonder if any local communities maintain tags whose keys have non-latin characters. I'm no expert in any of the many tools that could answer this, so no idea.
2. A check that the submission has any changes at all.
	- Makes sense to keep in the frontend.
3. A lack of validation for unique keys.
	- Currently this code parses tags in order, stuffing them in a `Map` as they come. This means that the last tag will win in case of duplication.
	- Makes sense to implement in the frontend.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6758#issuecomment-3909040435
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6758/c3909040435 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260216/1563d2d7/attachment.htm>


More information about the rails-dev mailing list