[openstreetmap/openstreetmap-website] Migrate the edit location page from leaflet to Maplibre (PR #6675)

Frank Elsinga notifications at github.com
Mon Jan 5 07:52:04 UTC 2026


@CommanderStorm commented on this pull request.



> +    map = new maplibregl.Map({
+      container: "map",
+      style: OSM.MapLibre.Styles.Mapnik,
       attributionControl: false,
-      zoomControl: false
-    }).addLayer(new L.OSM.Mapnik());
+      locale: OSM.MapLibre.Locale,
+      rollEnabled: false,
+      dragRotate: false,
+      pitchWithRotate: false,
+      bearingSnap: 180,
+      maxPitch: 0,
+      center: OSM.home ? [OSM.home.lon, OSM.home.lat] : [0, 0],
+      zoom: OSM.home ? defaultHomeZoom : 0
+    });

If there are two item of something I don't think the added complexity of reasoning about that is worth it.
Reasoning how this OSM global and the /== imports work is already a large overhead.
Lets not add more overhead.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6675#discussion_r2660583329
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6675/review/3625805244 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260104/da101221/attachment.htm>


More information about the rails-dev mailing list