[openstreetmap/openstreetmap-website] Avoid language selector breaking on submit (PR #6682)
Pablo Brasero
notifications at github.com
Tue Jan 6 16:47:45 UTC 2026
Fixes https://github.com/openstreetmap/openstreetmap-website/issues/6598
Avoid submission of the language selection form as it is intended only as a filter for the options below. Submission not only doesn't make sense, it also breaks the form.
This is extracted from my comment at https://github.com/openstreetmap/openstreetmap-website/pull/6599#issuecomment-3636677922. I'm not adding tests because this is not trivial to test with Capybara. I have only tested manually, please others confirm that it fixes the problem for you.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6682
-- Commit Summary --
* Avoid language selector breaking on submit
-- File Changes --
M app/assets/javascripts/language_selector.js (4)
M app/views/languages_panes/show.html.erb (2)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/6682.patch
https://github.com/openstreetmap/openstreetmap-website/pull/6682.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6682
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6682 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260106/146eaec6/attachment.htm>
More information about the rails-dev
mailing list