[openstreetmap/openstreetmap-website] Add demo links for routing engine directions Fixes #6387 (PR #6693)
Marwin Hochfelsner
notifications at github.com
Thu Jan 15 17:02:10 UTC 2026
@hlfan approved this pull request.
Ok, the changes overall look good to me, but the commit message is a bit vague.
I think it would be clearer with
- all the feature changes in one commit (maybe titled alike the PR)
- and the added newlines for readability in another.
Final nit while you're rebasing: the JS spread syntax is usually written without a trailing space, aka `"..._processDirections"` instead of `"... _processDirections"`.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6693#pullrequestreview-3666653166
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6693/review/3666653166 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260115/d6699c93/attachment.htm>
More information about the rails-dev
mailing list