Re: [openstreetmap/openstreetmap-website] Update route markers and context menu icons to cursor/flag metaphor (… (PR #6716)
Anshul Zilpe
notifications at github.com
Fri Jan 16 14:16:51 UTC 2026
@aNsHuL5217 commented on this pull request.
> @@ -18,8 +18,8 @@
"tick" => { :"stroke-linecap" => "round", :"stroke-linejoin" => "round", :fill => "none", :d => "M7.157 14.649Q8.9 16 11.22 18.761 14.7 11.7 17.843 8.239" },
"cross" => { :"stroke-linecap" => "round", :d => "m7.5 8 10 10m0-10-10 10" },
"minus" => { :"stroke-linecap" => "round", :d => "M5.75 13h13.5" },
- "play" => { :"stroke-linejoin" => "round", :fill => "#fff", :d => "M10 17.5v-9l7 4.5z" },
- "stop" => { :"stroke-linejoin" => "round", :fill => "#fff", :d => "M9 9.5h7v7H9z" },
+ "play" => { :"stroke-linejoin" => "round", :fill => "#fff", :d => "M5.5 13h7v7l5-12z" },
Agreed. Since the media metaphors no longer fit, I have renamed the keys `play` → `start` and `stop` → `destination` across the codebase (including `directions.js`, the markers partial, and the map layout) to match the new semantics.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6716#discussion_r2698683881
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6716/review/3671089736 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260116/b2ba9d4a/attachment.htm>
More information about the rails-dev
mailing list