[openstreetmap/openstreetmap-website] Use MapLibre class extensions to DRY code (PR #6726)

[Tom Hughes]

@tomhughes commented on this pull request.

I think it's probably a bit silly moving `CombinedControlGroup` to `maplibre/dom_util` in one commit and then moving it again to `maplibre/controls` in the next one - why not just move it directly to the final location in the first commit?

> @@ -0,0 +1,48 @@
+//= require maplibre-gl/dist/maplibre-gl
+//= require maplibre/controls
+//= require maplibre/dom_util
+//= require maplibre/styles
+
+maplibregl.Map.prototype._getUIString = function (key) {

As we're already extending the map class can we not just put a replacement `_getUIString` there rather than monkey patching maplibregl? or would that not work?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6726#pullrequestreview-3679547828
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6726/review/3679547828 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260119/c08c9c85/attachment.htm>