[openstreetmap/openstreetmap-website] Fix keyboard navigation for richtext field tabs in New Diary Entry (PR #6691)
Pablo Brasero
notifications at github.com
Tue Jan 20 11:42:37 UTC 2026
pablobm left a comment (openstreetmap/openstreetmap-website#6691)
There's one thing I don't understand: why does this bug exist in the first place? It looks like something we might have introduced ourselves, rather than a Bootstrap behaviour. I am concerned that adding more JS is only going to introduce complexity without fixing the issue at source.
Also I don't understand what the default behaviour in Bootstrap is. The examples at https://getbootstrap.com/docs/5.0/components/navs-tabs/#javascript-behavior use tab to navigate between tabs. However [a quick jsbin with the same code](https://jsbin.com/sisexiy/edit?html,output) has it working with the arrow keys instead... although at least it doesn't "overflow" like it happens in our bug.
Whichever the correct behaviour is, I would expect that the fix would be one of removing code, rather than adding more JS, and particularly JS that checks on specific key codes.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6691#issuecomment-3772456424
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6691/c3772456424 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260120/59364670/attachment-0001.htm>
More information about the rails-dev
mailing list