[openstreetmap/openstreetmap-website] Deconvolute linkify logic (PR #6720)

[Pablo Brasero]

@pablobm commented on this pull request.

Looking at the tests, I see there's a `test_deactivated_linkify_expansion_in_markdown`. Should we add a `test_deactivated_linkify_expansion_in_html`?

> @@ -87,18 +87,33 @@ def sanitize(text)
       Sanitize.clean(text, Sanitize::Config::OSM).html_safe
     end
 
-    def linkify(text, mode = :urls)
-      ERB::Util.html_escape(text)
-               .then { |html| expand_link_shorthands(html) }
-               .then { |html| expand_host_shorthands(html) }
-               .then { |html| auto_link(html, mode) }
-               .html_safe
+    def linkify(text, mode = :urls, hosts: true, paths: true)
+      link_attr = 'rel="nofollow noopener noreferrer" dir="auto"'
+      html = ERB::Util.html_escape(text)
+
+      html = expand_link_shorthands(html) if paths
+      html = expand_host_shorthands(html) if hosts

Is there any instance when `hosts` will be false? If not, should we remove the option altogether?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6720#pullrequestreview-3681959840
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6720/review/3681959840 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260120/f778f922/attachment.htm>