[openstreetmap/openstreetmap-website] Check response.ok before parsing JSON in query tool (PR #6724)

Areeb Siddiqui notifications at github.com
Tue Jan 20 17:45:10 UTC 2026


SykoDaedalus left a comment (openstreetmap/openstreetmap-website#6724)





> Ooof. The tests are failing because Overpass queries are stubbed for testing at:
> 
> https://github.com/openstreetmap/openstreetmap-website/blob/5b3210c5f637596ed65e75c2173990055b11fe5c/test/system/query_features_test.rb#L216-L218
> 
> Only `json` is present in the stub, so you'll have to add `ok` and that should be enough.

Thanks for the help, it worked.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6724#issuecomment-3774165383
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6724/c3774165383 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260120/b34e356a/attachment.htm>


More information about the rails-dev mailing list