[openstreetmap/openstreetmap-website] History: Gateway timeout error does not display properly (Issue #6282)

[Minh Nguyễn]

1ec5 left a comment (openstreetmap/openstreetmap-website#6282)

> In fact, this is a cloudflare error page embedded within the history section, instead of solely being short message or covering whole page, as opposed to 404 error (at /undefined) which is simple message covering whole page.

We moved away from Cloudflare in openstreetmap/chef#812, but I assume this is still relevant because of the lack of error handling in general.

> This seems to be lack of error handling. At least in app/assets/javascripts/index/history.js, fetch operations in loadFirstChangesets and loadMoreChangesets don't check HTTP status codes, and treat response error messages as normal HTML.

This code would be doing error checking similar to #6724:

https://github.com/openstreetmap/openstreetmap-website/blob/f8bbca1c6120df73a62dae26e25890f4b72ae8b3/app/assets/javascripts/index/history.js#L184-L188 https://github.com/openstreetmap/openstreetmap-website/blob/f8bbca1c6120df73a62dae26e25890f4b72ae8b3/app/assets/javascripts/index/history.js#L224-L228

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6282#issuecomment-3785384936
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/issues/6282/3785384936 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260122/9251c368/attachment.htm>