[openstreetmap/openstreetmap-website] Fix vector map route offset and marker sync race condition #6684 (PR #6731)

Tom Hughes notifications at github.com
Thu Jan 22 17:58:54 UTC 2026


@tomhughes commented on this pull request.

I wonder if this is something that should be more general? That `OSM.loadSidebarContent` should be listening for the transition it starts to finish and then poking the map and firing an event that the routing code can listen to?

Oddly I can't reproduce the behaviour that we see with routing with other things like object browse URLs than also open the sidebar and display overlays on the map but I don't know why!

> +      map.eachLayer((layer) => {
+        if (layer._glMap) {
+          layer._glMap.resize();
+        }
+      });
+      map.invalidateSize({ animate: false });

So the maplibre-gl plugin for leaflet doesn't respond correctly to size invalidation I assume, hence the need to manually poke those layers? Has that been reported to maplibre-gl-leaflet upstream?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6731#pullrequestreview-3693800302
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6731/review/3693800302 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260122/af950725/attachment.htm>


More information about the rails-dev mailing list