[openstreetmap/openstreetmap-website] Minimap migration from Leaflet to MapLibre (PR #6683)
Frank Elsinga
notifications at github.com
Wed Jan 28 19:43:05 UTC 2026
@CommanderStorm commented on this pull request.
> @@ -4,6 +4,7 @@
//= depend_on legend.yml
OSM = {
+ RAILS_ENV: "<%= Rails.env %>",
I can change it to something like `OSM.PRODUCTION_ENVIRONMENT` (`OSM.validateStyle` is a bit too specific imo and does not match the captalisation for constants).
Readability of `OSM.RAILS_ENV === 'production'` is in my oppinon a bit higher, as this way it is clear tht the environment comes from rails.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6683#discussion_r2738310698
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6683/review/3718778989 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260128/f9d6d901/attachment.htm>
More information about the rails-dev
mailing list