[openstreetmap/openstreetmap-website] handle API errors with no content (PR #7194)
Pablo Brasero
notifications at github.com
Wed Jul 1 15:21:15 UTC 2026
pablobm left a comment (openstreetmap/openstreetmap-website#7194)
OK, only now I'm realising that you are talking about note comments, not notes themselves :sweat_smile: I was thinking of the latter because I worked on them recently. I didn't realise that comments had their own, parallel, and quite similar error handling. Probably should be DRY'd up, but not necessarily in this PR.
At https://github.com/openstreetmap/openstreetmap-website/pull/7132, I went with the message `Got response with status ${resp.status} ${resp.statusText}`, with no translation. Perhaps too wordy for an untranslated message though. I think starting with `HTTP Error 503:` and not translating it should be ok. We can't be expected to translate HTTP status messages, and they would make debugging more difficult anyway.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7194#issuecomment-4856871864
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/7194/c4856871864 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260701/99dbd6d6/attachment.htm>
More information about the rails-dev
mailing list