[openstreetmap/openstreetmap-website] On-site notifications (PR #7030)

[Pablo Brasero]

pablobm left a comment (openstreetmap/openstreetmap-website#7030)

> So I think my main question is about the "view tests" which is not something we've had before...

I should have mentioned it in the description. Yeah, view tests is something I have rarely used, but here I felt they might make sense. Putting together the tests properly in a controller was feeling like too much boilerplate. With the view tests I felt I could get these variants tested in a more straightforward manner, with the added bonus of avoiding the DB. Also I liked how in `ChangesetCommentViewTest` I could test two variants (`test_render_without_summary` and `test_render_with_summary`) without further enlarging the controller test.

A bit experimental; open to doing it in the controller test as normal.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7030#issuecomment-4875861700
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/7030/c4875861700 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260703/1aa2fd08/attachment-0001.htm>