[openstreetmap/openstreetmap-website] Facebook deletion callback (PR #7093)

[Andy Allan]

@gravitystorm requested changes on this pull request.



> @@ -233,9 +233,16 @@
   get "/forgot-password.html", :to => redirect(:path => "/user/forgot-password")
 
   # omniauth
-  get "/auth/failure" => "users#auth_failure"
-  match "/auth/:provider/callback" => "users#auth_success", :via => [:get, :post], :as => :auth_success
-  match "/auth/:provider" => "users#auth", :via => [:post, :patch], :as => :auth
+  scope "/auth", :as => :auth do
+    get "/failure" => "users#auth_failure"
+
+    scope ":provider" do
+      match "/callback" => "users#auth_success", :via => [:get, :post], :as => :success
+      match "" => "users#auth", :via => [:post, :patch]
+
+      resource :delete, :only => [:show, :create], :module => "accounts", :controller => "auth_deletions"

I'd vote for `resource :deletions`. Definitely not `resource :delete` though, that's confusing!

For `deletion` vs `deletions` - the plural is the one that most closely matches the controller name, and it makes sense to have the controller in plural.

Ideally we don't override the controller name at all, and it should be generated automatically based on the resource name. However, with the existing "auth" scope, and the module override, it's already becoming a tangle, so let's keep the override and align the resource name as much as makes sense.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7093#pullrequestreview-4656111566
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/7093/review/4656111566 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260708/837d1e08/attachment.htm>