[openstreetmap/openstreetmap-website] Make loadSidebarContent use promises (PR #7226)

Tom Hughes notifications at github.com
Tue Jul 14 17:50:45 UTC 2026


@tomhughes commented on this pull request.



>          const title = response.headers.get("X-Page-Title");
         if (title) document.title = decodeURIComponent(title);

I'm not sure I understand the reason for moving this later - the commit says it's moving it so the title is only updated after content download but I can't see what has changed about when the content download is done? or is there some existing bug here that you've fixed?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7226#pullrequestreview-4697094963
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/7226/review/4697094963 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260714/97a0a719/attachment.htm>


More information about the rails-dev mailing list