[openstreetmap/openstreetmap-website] Make loadSidebarContent use promises (PR #7226)

Tom Hughes notifications at github.com
Tue Jul 14 19:22:02 UTC 2026


@tomhughes commented on this pull request.



>          const title = response.headers.get("X-Page-Title");
         if (title) document.title = decodeURIComponent(title);

I mean I don't entirely even know what constitutes the content being downloaded but I assume you're saying the initial promise is resolved by fetch as soon as it has the headers and only once the promise returned by the `text` function on the response is resolved is the content guaranteed to be complete?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7226#discussion_r3581988045
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/7226/review/4697784366 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260714/40e9ce40/attachment-0001.htm>


More information about the rails-dev mailing list