[openstreetmap/openstreetmap-website] On-site notifications (PR #7030)

[Pablo Brasero]

pablobm left a comment (openstreetmap/openstreetmap-website#7030)

Yeah, that's fair. I'll address each point in a different comment, for clarity.

On the general point about the large amount of changes, how about this: I have brought the branch back to where it was before. The changes that I added later can come at a later stage in the form of separate PRs. They are isolated enough.

I have squashed a couple of things in though, as they were small and I thought made sense. This is them, for clarity:
- Renamed translation keys from "cta" to "link" (roughly) as they are not "calls to action".
- Renamed system test from `OnsiteNotificationsTest` to `WebNotificationsTest` as the term "on-site notification" is not really used anywhere.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7030#issuecomment-5023147565
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/7030/c5023147565 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260720/5535e705/attachment.htm>