[openstreetmap/openstreetmap-website] On-site notifications (PR #7030)

[Tom Hughes]

tomhughes left a comment (openstreetmap/openstreetmap-website#7030)

I've had another look through this and I think I'm happy with it now, except for the question of trying to decide if I like the view tests.

My primary concern really is whether we're leaving code untested in the controllers by jumping straight to the views, along with the amount of boilerplate that seems to be needed to stub everything - it's interesting you say that it was the amount of boilerplate needed to do it as controller tests that made you go for view tests because it was the amount of boilerplate in the view tests that first drew my attention to what was going on.

Interestingly I had a quick look at the additional commits that you've now removed and I like a lot of what they're doing and it also seems to remove some of the stubbing in the view tests (the use of `Struct` to fake things) that was really concerning me.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7030#issuecomment-5038321654
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/7030/c5038321654 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260721/ba04b335/attachment.htm>