[openstreetmap/openstreetmap-website] On-site notifications (PR #7030)
Tom Hughes
notifications at github.com
Wed Jul 22 17:38:59 UTC 2026
tomhughes left a comment (openstreetmap/openstreetmap-website#7030)
Thanks for looking at it again, and for the improvements to the stubbing in the tests which does look a lot nicer now.
I wouldn't say I'm totally convinced but I've looked at coveralls and we seem to have essentially full coverage of the relevant files so I don't think my concerns there are an issue so I think we should go ahead and merge this.
Thanks again for all the work, and I'll look forward to seeing some of the followup work in separate PRs.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7030#issuecomment-5049423799
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/7030/c5049423799 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260722/09ffdf6f/attachment.htm>
More information about the rails-dev
mailing list