[openstreetmap/openstreetmap-website] Clean up promise related code (PR #7265)
Marwin Hochfelsner
notifications at github.com
Thu Jul 23 17:23:28 UTC 2026
@hlfan commented on this pull request.
> if (!route) return false;
routingInProgress = routingInProgress
.catch(() => {})
.then(async () => {
await currentRoute.run("unload", null, route === currentRoute);
+ map.setState(state, { animate: false });
Yeah that might make the callback way better. Dropped.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7265#discussion_r3640068514
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/7265/review/4766551712 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260723/abf2eb6c/attachment-0001.htm>
More information about the rails-dev
mailing list