[openstreetmap/openstreetmap-website] Build export download links from locale keys (PR #7271)

[Tom Hughes]

@tomhughes commented on this pull request.

Please squash the fixup commits into the base commit in line with our [policy](https://github.com/openstreetmap/openstreetmap-website/blob/master/CONTRIBUTING.md#pull-requests).

>  
-    <dt><a href="https://download.geofabrik.de/"><%= t ".too_large.geofabrik.title" %></a></dt>
-    <dd><%= t ".too_large.geofabrik.description" %></dd>
-
-    <dt><a href="https://wiki.openstreetmap.org/wiki/Download"><%= t ".too_large.other.title" %></a></dt>
-    <dd><%= t ".too_large.other.description" %></dd>
+  <dl class="px-3">
+    <% sources.each do |source| %>

I'm not sure there's much point creating a variable for the list of sources when we're only going to use it once. Why not just do this:
```suggestion
    <% %w[overpass planet geofabrik other].each do |source| %>
```
and then drop the variable?

> @@ -476,6 +476,19 @@ def test_export
     assert_template :layout => "xhr"
   end
 
+  # Test that the export page's bulk download links are built from locale keys

That's not really what it's doing though, is it? Sure you're testing that the value it uses is the same as the one in the locale file but there's no way for the test to be sure it actually used the locale file.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7271#pullrequestreview-4821695107
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/7271/review/4821695107 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260730/2ed726ec/attachment.htm>