[openstreetmap/openstreetmap-website] Display error message if note creation fails (PR #7132)

[Pablo Brasero]

Working with Moderation Zones (PR to come), I had a test where I needed to tell if note creation had failed. Then I thought it actually should be clear to users too, so solving two problems at once here.

<img width="345" height="670" alt="The note creation form, showing a message notifying that a note wasn't created due to an error" src="https://github.com/user-attachments/assets/81eb853b-f33f-43ea-8533-9900e77e31c9" />

Something specific that might be controversial: I'm altering an eslint rule to allow unused variables whose name starts with underscore. This is because I have a `_err` argument that I'd rather keep for clarity, even if I don't use it.

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/7132

-- Commit Summary --

  * eslint: allow unused variables if prefixed with underscore
  * Display error message if note creation fails

-- File Changes --

    M app/assets/javascripts/index/new_note.js (43)
    M app/views/notes/new.html.erb (1)
    M config/eslint.config.mjs (2)
    M config/locales/en.yml (3)
    M test/system/create_note_test.rb (18)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/7132.patch
https://github.com/openstreetmap/openstreetmap-website/pull/7132.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7132
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/7132 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260604/f1d45554/attachment.htm>