[openstreetmap/openstreetmap-website] Add query parameter to suppress display of signup UI elements (PR #7138)

[Simon Poole]

@simonpoole commented on this pull request.



> @@ -11,14 +11,16 @@
   <% end %>
 
   <div class="d-flex align-items-end">
-    <ul class="nav nav-tabs fs-6">
-      <li class="nav-item">
-        <%= link_to t("sessions.new.tab_title"), "#", :class => "nav-link active" %>
-      </li>
-      <li class="nav-item">
-        <%= link_to t("users.new.tab_title"), url_for(:action => :new, :controller => :users, :referer => params[:referer]), :class => "nav-link" %>
-      </li>
-    </ul>
+    <% if @allow_signup %>

It's the eternal question for non-rails developers writing something in Ruby/Rails: what is the current idiomatic way of doing things? 

But the change makes me feel a lot better about the whole thing as it would seem to be a lot less brittle and fail safe.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7138#discussion_r3372222597
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/7138/review/4448291690 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260608/b27e4f77/attachment.htm>