[openstreetmap/openstreetmap-website] Add query parameter to suppress display of signup UI elements (PR #7138)

[Tom Hughes]

@tomhughes commented on this pull request.



> @@ -75,10 +75,12 @@
         </div>
       </div>
     <% else %>
-      <div class="d-inline-flex btn-group login-menu">
-        <%= link_to t(".log_in"), login_path(:referer => request.fullpath), :class => "geolink btn btn-outline-secondary" %>
-        <%= link_to t(".sign_up"), new_user_path, :class => "btn btn-outline-secondary" %>
-      </div>
+      <% unless allow_signup == false %>

How about renaming the parameter to `hide_signup` or something, reversing the sense of the URL parameter comparison to `== "false"` and then using `unless high_signup`? It at least gets rid of the `== false` code smell even if there's still a sort of double negative... I think it would be clearer what was happening?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7138#discussion_r3375812080
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/7138/review/4452756691 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260608/4e413413/attachment-0001.htm>