[openstreetmap/openstreetmap-website] Add query parameter to suppress display of signup UI elements (PR #7138)

[Marwin Hochfelsner]

@hlfan commented on this pull request.

With the separate cookie store of a web login page embedded inside a native app, maybe that flag should be stored in a session cookie as well. Then User.new could actually respond with a 403 instead of still working.

> @@ -75,10 +75,12 @@
         </div>
       </div>
     <% else %>
-      <div class="d-inline-flex btn-group login-menu">
-        <%= link_to t(".log_in"), login_path(:referer => request.fullpath), :class => "geolink btn btn-outline-secondary" %>
-        <%= link_to t(".sign_up"), new_user_path, :class => "btn btn-outline-secondary" %>
-      </div>
+      <% unless hide_signup %>
+        <div class="d-inline-flex btn-group login-menu">
+          <%= link_to t(".log_in"), login_path(:referer => request.fullpath), :class => "geolink btn btn-outline-secondary" %>

Does the login button really need to be hidden here and not just the sign up one?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7138#pullrequestreview-4455493859
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/7138/review/4455493859 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260608/963559b0/attachment.htm>