[openstreetmap/openstreetmap-website] Make GPS traces feature optional via gps_traces_enabled setting (PR #7156)

[Pablo Brasero]

@pablobm commented on this pull request.



> @@ -2,6 +2,7 @@
 
 module Api
   class TracepointsController < ApiController
+

Remember to remove these rogue newlines 🙂 (I know it's from removing those before_actions).

>              <li>
               <%= link_to t(".my traces"), :controller => "traces", :action => "mine" %>
               <span class="badge count-number"><%= number_with_delimiter(current_user.traces.size) %></span>
             </li>
+            <% end %>

I think the content inside should be indented, to be consistent with similar code. Not sure if this is something that can be configured in the linters. Perhaps the maintainers disagree?

>              <li>
               <%= link_to t(".traces"), :controller => "traces", :action => "index", :display_name => @user.display_name %>
               <span class="badge count-number"><%= number_with_delimiter(@user.traces.size) %></span>
             </li>
+            <% end %>

Same here.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7156#pullrequestreview-4532022683
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/7156/review/4532022683 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260619/72f1d408/attachment-0001.htm>