[openstreetmap/openstreetmap-website] Make GPS traces feature optional via gps_traces_enabled setting (PR #7156)

[Lee Kindness]

@wangi commented on this pull request.



> @@ -76,6 +76,7 @@
     required(:api_version).filled(:str?)
     required(:max_request_area).filled(:number?)
     required(:max_note_request_area).filled(:number?)
+    required(:traces_enabled).filled(:bool?)

`settings.yml` provides the default so it's always present, and put `required` here to cover it being missing in the yml (existing installs?)

I did also consider that the setting should be `traces_disabled`... no `config.rb` change and the tests along the lines of `can [:read, :data], Trace unless Settings.traces_disabled`. I wasn't a fan of the negative, but the test is clean.

What do you think?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7156#discussion_r3477784013
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/7156/review/4575133310 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260625/41fa3902/attachment-0001.htm>