[openstreetmap/openstreetmap-website] Refactor some code to be ready to accept the new maplibre main map (PR #7189)
Frank Elsinga
notifications at github.com
Sat Jun 27 16:06:51 UTC 2026
### Description
a 3-in-1 change, but a low effect one, so I grouped it:
- app/assets/javascripts/feature_label.js is code that I need separate from the query feature since I need it for fixing the popup on the data inspector page instead of just the query page
- maplibre does not support spaced event listener
### How has this been tested?
Looking at the code, seeing that the query feature still works
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/7189
-- Commit Summary --
* Make sure to not use the space separated event listeners anywhere
* Fix one code duplication
* Move feature labeling code to its own module to be ready for a second connsumer in maplibres data layer
-- File Changes --
A app/assets/javascripts/feature_label.js (39)
M app/assets/javascripts/index.js (13)
M app/assets/javascripts/index/contextmenu.js (4)
M app/assets/javascripts/index/initializations.js (9)
M app/assets/javascripts/index_modules/query.js (60)
M app/assets/javascripts/router.js (4)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/7189.patch
https://github.com/openstreetmap/openstreetmap-website/pull/7189.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7189
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/7189 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260627/9bffa20a/attachment-0001.htm>
More information about the rails-dev
mailing list