[openstreetmap/openstreetmap-website] Make traces feature optional via traces_disabled setting (PR #7156)

[Lee Kindness]

wangi left a comment (openstreetmap/openstreetmap-website#7156)

> Actually, should have thought of this earlier: how about naming the setting in the positive (`traces_enabled`, default `true`) rather than the negative? I find negatives trickier to reason about, particularly when it comes to conditionals, be it `if !Setting.traces_disabled` or `unless Setting.traces_disabled`.

That's how it started out (see [c064247](https://github.com/openstreetmap/openstreetmap-website/commit/c0642472d51b233c7c8137d043cb9229f9651d37)) before I flipped it around based on hlfan's feedback. I do now agree that `traces_disabled` makes sense, matches in with the intent and is consistent with other cases (e.g. #7138). However, I did originally have the same discomfort with the negative! 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7156#issuecomment-4831437861
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/7156/c4831437861 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260629/3a0a93ab/attachment.htm>