[openstreetmap/openstreetmap-website] A new foundation for user notifications (PR #6837)

[Pablo Brasero]

@pablobm commented on this pull request.



> @@ -44,9 +44,7 @@ def create
                                           :author => current_user)
 
       # Notify current subscribers of the new comment
-      changeset.subscribers.visible.each do |user|
-        UserMailer.changeset_comment_notification(comment, user).deliver_later if current_user != user
-      end
+      ChangesetCommentNotifier.with(:record => comment).deliver

That probably makes sense. When I was looking into this, I wondered too if `deliver` meant `_now` or `_later`. Better make it explicit for everyone to understand.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6837#discussion_r2918253987
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6837/review/3929473003 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260311/54a57b37/attachment.htm>