[openstreetmap/openstreetmap-website] Some helpers for cleaner mailer tests (PR #6877)

Marwin Hochfelsner notifications at github.com
Wed Mar 11 16:17:07 UTC 2026


@hlfan commented on this pull request.



> @@ -24,7 +24,7 @@ def test_gpx_description_tags
   def test_gpx_success_all_traces_link
     trace = create(:trace)
     email = UserMailer.gpx_success(trace, 100)
-    url = Rails.application.routes.url_helpers.url_for(:controller => "traces", :action => "mine", :host => Settings.server_url, :protocol => Settings.server_protocol)
+    url = url_for_email(:controller => "traces", :action => "mine")

Can `url_for_email` be dropped?
```suggestion
    url = url_helpers.url_for(:controller => "traces", :action => "mine")
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6877#pullrequestreview-3930820844
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6877/review/3930820844 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260311/bda31852/attachment.htm>


More information about the rails-dev mailing list