[openstreetmap/openstreetmap-website] Apply lang attribute to localized name:* values (#6834) (PR #6854)
Arpan Mukherjee
notifications at github.com
Thu Mar 12 09:38:19 UTC 2026
Arpan200502 left a comment (openstreetmap/openstreetmap-website#6854)
> In addition to my inline suggestions can you fix the commit to not have a 180+ character first line?
>
> To be honest I'd just go with something like:
>
> ```
> Fix language detection for name:* tags in data browser
> ```
>
> I'm not sure mentioning specific files in the commit comment is a good idea, and including tests for the change is something that's expected and doesn't really need to be mentioned explicitly but if you do want to add more detail then do it in a separate paragraph and keep the initial subject line short.
Thanks for the suggestions.
* Updated the commit message to keep the first line within the 80-character limit.
* Inlined `tag_language(tag[0])` in the `content_tag` call and removed the temporary `lang` variable, since it was only used once.
* Fixed the indentation accordingly.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6854#issuecomment-4045287711
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6854/c4045287711 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260312/29a55e9d/attachment-0001.htm>
More information about the rails-dev
mailing list