[openstreetmap/openstreetmap-website] Add Codeberg social link icon and URL pattern support (#6814) (PR #6855)

[Arpan Mukherjee]

Arpan200502 left a comment (openstreetmap/openstreetmap-website#6855)

> I just had a look. I can see the icon in dark mode, but not in light mode:
> 
> <img alt="Example of social link on light mode. No icon showing." width="296" height="115" src="https://private-user-images.githubusercontent.com/36066/562352082-279519a1-0bcb-41ab-bc4c-0b443a33b8ad.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzMzMjg2NDQsIm5iZiI6MTc3MzMyODM0NCwicGF0aCI6Ii8zNjA2Ni81NjIzNTIwODItMjc5NTE5YTEtMGJjYi00MWFiLWJjNGMtMGI0NDNhMzNiOGFkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAzMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMzEyVDE1MTIyNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTJkMDk5Yjc0ZTdjZjE5NzIwODE0MTM5MjE4NDRlNzA1MDExMzJjMGNiYzk3ODVmYTZiZWI4ZWYzNmNjNTY4ZDImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.lOwOBUEMB-DJ7uzRGyrRIPu1tHnrUNzU5dwv91YJ7Io"> <img alt="Example of social link on dark mode. The Codeberg icon is showing." width="296" height="115" src="https://private-user-images.githubusercontent.com/36066/562352135-83cf3b4d-0520-4fb8-9667-3049bfe0ee01.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzMzMjg2NDQsIm5iZiI6MTc3MzMyODM0NCwicGF0aCI6Ii8zNjA2Ni81NjIzNTIxMzUtODNjZjNiNGQtMDUyMC00ZmI4LTk2NjctMzA0OWJmZTBlZTAxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAzMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMzEyVDE1MTIyNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRmNmYwNTM4N2YzZWYyNTFmNTIzMjg2NzUzYmJiZTg4MDE2ZWE1ZDU0ZmQ3OWYwMzUxYzY5NTk2M2I2ZWZhNDUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.fokzpYLUsQ2r-QrpgtWSIFBg8Ey2MEAL3xgx4L7_ld8">
> Re: optimising the inline SVGs. Could it be that they are actually being optimised? The docs for `inline_svg` say:
> 
> > This gem adds Rails helper methods (`inline_svg_tag` and `inline_svg_pack_tag`) that read an SVG document (via Sprockets or Shakapacker, so works with the Rails Asset Pipeline), applies a CSS class attribute to the root of the document and then embeds it into a view.
> 
> In turn, [image_optim_rails](https://github.com/toy/image_optim_rails) works with Sprockets. Therefore the inline SVGs might be benefitting?

i mean there where 2 svg present i added the dark one ,,,,,,, and before changed the internal code of the svg to give it more of a greylook which would be seen on both dark and light mode , like inthe first picture of this pullreq,,,,

but now i added the official svg without any changes , should i go ahead and change some internal confi to make it visible on both modes ?? or some other approce will be better >?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6855#issuecomment-4047569777
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6855/c4047569777 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260312/c3eb76b8/attachment.htm>