[openstreetmap/openstreetmap-website] Add parse_html helper to tests (PR #6886)
Tom Hughes
notifications at github.com
Thu Mar 12 17:40:01 UTC 2026
Like @hlfan I noticed when reviewing #6877 that there was further scope for sharing the HTML parsing boilerplate so that is what this does by moving much of `parse_html_body` up to a shared `parse_html` method that can be used by the helper tests.
It also fixes one remaining mailer test that #6877 missed to use `parse_html_body`.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6886
-- Commit Summary --
* Convert a missed mailer test to use parse_html_body
* Add a parse_html test helper to reduce boilerplate
-- File Changes --
M test/helpers/browse_helper_test.rb (10)
M test/helpers/browse_tags_helper_test.rb (10)
M test/helpers/changesets_helper_test.rb (6)
M test/helpers/issues_helper_test.rb (8)
M test/helpers/note_helper_test.rb (8)
M test/helpers/numbered_pagination_helper_test.rb (40)
M test/helpers/share_buttons_helper_test.rb (2)
M test/mailers/user_mailer_test.rb (5)
M test/test_helper.rb (4)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/6886.patch
https://github.com/openstreetmap/openstreetmap-website/pull/6886.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6886
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6886 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260312/9b248563/attachment.htm>
More information about the rails-dev
mailing list