[openstreetmap/openstreetmap-website] Convert all mailers to the newer, keyword style (PR #6888)

[Pablo Brasero]

As part of the groundwork for https://github.com/openstreetmap/openstreetmap-website/pull/6837, this converts all existing mailers to the newer style allowed by Rails, where arguments are passed via `#with` by keyword, and read from `params` on the other side.

This is done purely to accommodate the gem [Noticed](https://github.com/excid3/noticed), which requires less boilerplate for mailers of this form. In addition, it's the form shown in the guides, making it reasonable to assume that new contributors will be more familiar with this form than with the "classic" one (which is not deprecated).
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/6888

-- Commit Summary --

  * Convert `UserMailer#signup_confirm` to new style
  * Convert `UserMailer#email_confirm` to new style
  * Convert `UserMailer#lost_password` to new style
  * Convert `UserMailer#diary_comment_notification` to new style
  * Convert `UserMailer#follow_notification` to new style
  * Convert `UserMailer#gpx_success` to new style
  * Convert `UserMailer#gpx_failure` to new style
  * Convert `UserMailer#message_notification` to new style
  * Convert `UserMailer#note_comment_notification` to new style
  * Convert `UserMailer#changeset_comment_notification` to new style

-- File Changes --

    M app/controllers/api/changeset_comments_controller.rb (2)
    M app/controllers/api/messages_controller.rb (2)
    M app/controllers/api/notes_controller.rb (2)
    M app/controllers/concerns/user_methods.rb (2)
    M app/controllers/confirmations_controller.rb (5)
    M app/controllers/diary_comments_controller.rb (2)
    M app/controllers/follows_controller.rb (2)
    M app/controllers/messages_controller.rb (2)
    M app/controllers/passwords_controller.rb (2)
    M app/controllers/users_controller.rb (6)
    M app/jobs/trace_importer_job.rb (8)
    M app/mailers/user_mailer.rb (41)
    M script/deliver-message (2)
    M test/controllers/users_controller_test.rb (2)
    M test/mailers/previews/user_mailer_preview.rb (22)
    M test/mailers/user_mailer_test.rb (28)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/6888.patch
https://github.com/openstreetmap/openstreetmap-website/pull/6888.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6888
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6888 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260313/af247ce4/attachment-0001.htm>