[openstreetmap/openstreetmap-website] A new foundation for user notifications (PR #6837)

Pablo Brasero notifications at github.com
Mon Mar 16 14:25:54 UTC 2026


pablobm left a comment (openstreetmap/openstreetmap-website#6837)

One additional irritation about Noticed: notifiers expect that there will be an argument called `record` (the thing that we are notifying about). This in turn will be passed to mailers, etc. For example, we currently have this:
```
UserMailer.with(:comment => comment, :recipient => recipient).note_comment_notification
```

If we leave things to follow Noticed's conventions, we have to turn that into this:
```
UserMailer.with(:record => comment, :recipient => recipient).note_comment_notification
```

See the commit "First use of gem `noticed` to deliver notifications" to see what the necessary changes are.

Alternatively, we continue using the second form, but then every notifier needs additional configuration. We still would be expected to call `ChangesetCommentNotifier` with `:record`.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6837#issuecomment-4068050780
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6837/c4068050780 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260316/4494352b/attachment.htm>


More information about the rails-dev mailing list