[openstreetmap/openstreetmap-website] Migrate `/export/embed.html` from leaflet to maplibre (PR #6804)
Frank Elsinga
notifications at github.com
Wed Mar 18 23:06:08 UTC 2026
@CommanderStorm commented on this pull request.
> @@ -30,9 +30,9 @@ OSM.MapLibre.CombinedControlGroup = class CombinedControlGroup {
const icon = iconMap[type];
if (icon) {
- $(button)
- .empty()
- .append($("<i>").addClass(`maplibregl-ctrl-icon fs-5 bi bi-${icon}`));
+ const iconElement = document.createElement("i");
because otherwise the embed would need JQuery, which seems unnessary
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6804#pullrequestreview-3971390706
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6804/review/3971390706 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260318/bf47136d/attachment-0001.htm>
More information about the rails-dev
mailing list