[openstreetmap/openstreetmap-website] Fix new Herb warnings (PR #6913)

Marwin Hochfelsner notifications at github.com
Thu Mar 19 07:49:03 UTC 2026


Fixes for most new Linting issues are pretty straightforward; the `users/show` nav is a bit tougher, so this can't be reenabled yet.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/6913

-- Commit Summary --

  * Remove empty control block
  * Remove unnecessary then keyword
  * Use i18n _html flag
  * Remove inline class name interpolation
  * Place ActionView helpers closer to view output
  * Deduplicate elements across branches

-- File Changes --

    M .herb.yml (10)
    M app/views/api/notes/_comment.html.erb (12)
    M app/views/browse/_relation_member.html.erb (11)
    M app/views/browse/_way.html.erb (2)
    M app/views/changesets/history.html.erb (14)
    M app/views/diary_entries/index.html.erb (4)
    M app/views/issues/_page.html.erb (12)
    M app/views/notes/index.html.erb (21)
    M app/views/old_nodes/_not_found_message.html.erb (12)
    M app/views/old_relation_members/_not_found_message.html.erb (12)
    M app/views/old_relations/_not_found_message.html.erb (12)
    M app/views/old_ways/_not_found_message.html.erb (12)
    M app/views/traces/_trace.html.erb (7)
    M app/views/user_blocks/_block.html.erb (16)
    M app/views/user_mailer/_gpx_details.html.erb (12)
    M app/views/user_mailer/note_comment_notification.html.erb (6)
    M app/views/users/show.html.erb (3)
    M app/views/webgl_error_panes/show.html.erb (2)
    M config/locales/en.yml (2)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/6913.patch
https://github.com/openstreetmap/openstreetmap-website/pull/6913.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6913
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6913 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260319/d4bb0f93/attachment.htm>


More information about the rails-dev mailing list