[openstreetmap/openstreetmap-website] Collect user action item definitions (PR #6914)
Andy Allan
notifications at github.com
Thu Mar 19 09:42:24 UTC 2026
gravitystorm left a comment (openstreetmap/openstreetmap-website#6914)
I should expand my reasoning. If there's a list of links on a page, I expect to find the list of links built in the view template. For helpers, it's only really re-usable code that should go in to helpers - preferably something that accepts a parameter, since if it's a helper that just produces the same code every time, then a partial might be a better answer for that.
My concern is really just about where a new user expects to find the code. The more that we move out of views and into ruby functions written elsewhere, and the more that you have to figure out a more complex system to make a small change, the harder it is to reason about the code and make improvements.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6914#issuecomment-4088927242
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6914/c4088927242 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260319/dc5439a9/attachment.htm>
More information about the rails-dev
mailing list