[openstreetmap/openstreetmap-website] Migrate `/export/embed.html` from leaflet to maplibre (PR #6804)
Frank Elsinga
notifications at github.com
Thu Mar 19 13:15:30 UTC 2026
@CommanderStorm commented on this pull request.
> + attribHTML += termsLink.outerHTML;
+
+ // check if attribution string is different to minimize DOM changes
+ if (attribHTML === this._attribHTML) return;
+
+ this._innerContainer.innerHTML = attribHTML;
+ this._attribHTML = attribHTML;
+ this._updateCompact();
+
+ // Update report link href after initial render
+ if (this._includeReportLink) {
+ this._updateReportLink();
+ }
+ }
+
+ _buildCreditHtml(credit) {
third party layers?
Yes, it is only used in this class, since giving credit is very attribution specific
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6804#discussion_r2959979432
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6804/review/3975043251 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260319/e0ba948b/attachment.htm>
More information about the rails-dev
mailing list