[openstreetmap/openstreetmap-website] Migrate `/export/embed.html` from leaflet to maplibre (PR #6804)
Frank Elsinga
notifications at github.com
Thu Mar 19 13:38:49 UTC 2026
@CommanderStorm commented on this pull request.
>
- this._container.innerHTML =
- this._container.innerHTML
- .replace("{x}", this._map.getCenter().lat)
- .replace("{y}", this._map.getCenter().lng)
- .replace("{z}", this._map.getZoom());
+ if (args.has("marker")) {
+ const markerCoords = args.get("marker").split(",").map(parseFloat);
+ new maplibregl.Marker({ color: "#7ebc6f" })
I left that part out because I understood from your comments ([design](https://github.com/openstreetmap/openstreetmap-website/pull/6804#discussion_r2796583839)
, [colors](https://github.com/openstreetmap/openstreetmap-website/pull/6804#discussion_r2796595865)) that the page should follow the default MapLibre design.
To make sure I implement this as intended, which parts should use the Leaflet, OSM design, or MapLibre styling?
Here are the options for clairity:
- All maplibre with OSM-green marker color
- All maplibre with leaflet default marker color
- Marker the leaflet marker with default leaflet color and buttons the MapLibre one
- Full OSM style, incl. how the buttons look
I'm happy to adjust things either way - just want to communicate the "SHOULD" state in terms of direction to avoid unnecessary churn for both of us 😉
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6804#discussion_r2960118063
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6804/review/3975193050 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260319/1fd449ee/attachment-0001.htm>
More information about the rails-dev
mailing list