[openstreetmap/openstreetmap-website] Enforce declaration of local variables for partials (PR #6920)

[Tom Hughes]

I'm working on enabling the `erb-no-instance-variables-in-partials` linter but as a first step and to make that easier this enables the optional `erb-strict-locals-required` linter and fixes all our partials to declare their local variables.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/6920

-- Commit Summary --

  * Enforce declaration of local variables for partials

-- File Changes --

    M .herb.yml (2)
    M app/helpers/application_helper.rb (2)
    M app/views/accounts/_go_public.html.erb (2)
    M app/views/accounts/terms/_terms.html.erb (2)
    M app/views/accounts/terms/_terms_declined_flash.html.erb (2)
    M app/views/api/notes/_comment.html.erb (2)
    M app/views/api/notes/_description.html.erb (2)
    M app/views/api/notes/_entry.html.erb (2)
    M app/views/application/_auth_button.html.erb (1)
    M app/views/application/_auth_providers.html.erb (2)
    M app/views/application/_settings_menu.html.erb (2)
    M app/views/application/_sidebar_header.html.erb (2)
    M app/views/browse/_common_details.html.erb (2)
    M app/views/browse/_containing_relation.html.erb (2)
    M app/views/browse/_node.html.erb (2)
    M app/views/browse/_relation.html.erb (2)
    M app/views/browse/_relation_member.html.erb (2)
    M app/views/browse/_relation_member_frame.html.erb (2)
    M app/views/browse/_tag.html.erb (2)
    M app/views/browse/_tag_details.html.erb (2)
    M app/views/browse/_way.html.erb (2)
    M app/views/changeset_comments/feeds/_comment.html.erb (2)
    M app/views/changeset_subscriptions/_heading.html.erb (2)
    M app/views/changesets/_changeset.html.erb (2)
    M app/views/changesets/_changeset_line.html.erb (1)
    M app/views/changesets/_elements.html.erb (2)
    M app/views/changesets/_not_found_message.html.erb (2)
    M app/views/changesets/_paging_nav.html.erb (2)
    M app/views/confirmations/_resend_success_flash.html.erb (2)
    M app/views/dashboards/_contact.html.erb (2)
    M app/views/dashboards/_popup.html.erb (2)
    M app/views/diary_entries/_diary_comment.html.erb (2)
    M app/views/diary_entries/_diary_entry.html.erb (2)
    M app/views/diary_entries/_diary_entry_heading.html.erb (2)
    M app/views/diary_entries/_form.html.erb (2)
    M app/views/diary_entries/_location.html.erb (2)
    M app/views/diary_entries/_navigation.html.erb (2)
    M app/views/diary_entries/_page.html.erb (2)
    M app/views/diary_entries/_profile_diaries.html.erb (2)
    M app/views/errors/_contact.html.erb (2)
    M app/views/issues/_comments.html.erb (2)
    M app/views/issues/_page.html.erb (2)
    M app/views/issues/_reports.html.erb (2)
    M app/views/issues/reporters/_reporters.html.erb (2)
    M app/views/languages_panes/_select_language_list.html.erb (2)
    M app/views/layouts/_banner.html.erb (2)
    M app/views/layouts/_content.html.erb (4)
    M app/views/layouts/_flash.html.erb (2)
    M app/views/layouts/_head.html.erb (2)
    M app/views/layouts/_header.html.erb (2)
    M app/views/layouts/_markers.html.erb (2)
    M app/views/layouts/_meta.html.erb (2)
    M app/views/layouts/_search.html.erb (2)
    M app/views/layouts/_select_language_button.html.erb (2)
    M app/views/layouts/_sidebar_close.html.erb (2)
    M app/views/messages/mailboxes/_heading.html.erb (2)
    M app/views/messages/mailboxes/_message.html.erb (2)
    M app/views/messages/mailboxes/_messages_table.html.erb (2)
    M app/views/messages/outboxes/_message.html.erb (2)
    M app/views/nodes/_not_found_message.html.erb (2)
    M app/views/notes/_not_found_message.html.erb (2)
    M app/views/notes/_notes_paging_nav.html.erb (2)
    M app/views/oauth2_applications/_application.html.erb (2)
    M app/views/oauth2_applications/_form.html.erb (2)
    M app/views/oauth2_authorized_applications/_application.html.erb (2)
    M app/views/old_elements/_actions.html.erb (2)
    M app/views/old_nodes/_not_found_message.html.erb (2)
    M app/views/old_relation_members/_not_found_message.html.erb (2)
    M app/views/old_relations/_not_found_message.html.erb (2)
    M app/views/old_ways/_not_found_message.html.erb (2)
    M app/views/preferences/preferences/_navigation.html.erb (2)
    M app/views/preferences/preferences/_update_success_flash.html.erb (2)
    M app/views/profiles/profile_sections/_navigation.html.erb (2)
    M app/views/redactions/_redaction.html.erb (2)
    M app/views/relation_members/_not_found_message.html.erb (2)
    M app/views/relations/_not_found_message.html.erb (2)
    M app/views/sessions/_suspended_flash.html.erb (2)
    M app/views/shared/_markdown_help.html.erb (2)
    M app/views/shared/_pagination.html.erb (2)
    M app/views/shared/_richtext_field.html.erb (2)
    M app/views/shared/_section_divider.html.erb (2)
    M app/views/site/_about_section.html.erb (4)
    M app/views/site/_add_a_note.html.erb (2)
    M app/views/site/_any_questions.html.erb (2)
    M app/views/site/_id.html.erb (2)
    M app/views/site/_potlatch.html.erb (2)
    M app/views/site/_potlatch2.html.erb (2)
    M app/views/social_links/_show.html.erb (2)
    M app/views/traces/_page.html.erb (2)
    M app/views/traces/_trace.html.erb (2)
    M app/views/traces/feeds/_description.html.erb (2)
    M app/views/user_blocks/_block.html.erb (2)
    M app/views/user_blocks/_navigation.html.erb (2)
    M app/views/user_blocks/_page.html.erb (2)
    M app/views/user_mailer/_gpx_details.html.erb (2)
    M app/views/user_mailer/_message_body.html.erb (2)
    M app/views/users/_auth_association.html.erb (2)
    M app/views/users/_role_icons.html.erb (2)
    M app/views/users/_sidebar_section.html.erb (3)
    M app/views/users/changeset_comments/_page.html.erb (2)
    M app/views/users/diary_comments/_page.html.erb (2)
    M app/views/users/lists/_page.html.erb (2)
    M app/views/users/lists/_user.html.erb (2)
    M app/views/ways/_not_found_message.html.erb (2)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/6920.patch
https://github.com/openstreetmap/openstreetmap-website/pull/6920.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6920
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6920 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260319/f8cbc8af/attachment-0001.htm>