[openstreetmap/openstreetmap-website] Migrate `/export/embed.html` from leaflet to maplibre (PR #6804)
Marwin Hochfelsner
notifications at github.com
Sat Mar 21 14:08:49 UTC 2026
@hlfan commented on this pull request.
>
- this._container.innerHTML =
- this._container.innerHTML
- .replace("{x}", this._map.getCenter().lat)
- .replace("{y}", this._map.getCenter().lng)
- .replace("{z}", this._map.getZoom());
+ if (args.has("marker")) {
+ const markerCoords = args.get("marker").split(",").map(parseFloat);
+ new maplibregl.Marker({ color: "#7ebc6f" })
Ah, well I think the slippy map parts should be consistent across the site. The minimal alterations argument was more for the UI. If the attribution container consistently mirrors the Leaflet style, that's fine too. But I'd leave most design changes for when leaflet is fully migrated away.
I'd go for the combination of native maplibre nav controls together with the osm green accent and OSM.MapLibre attribution & marker.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6804#discussion_r2969628980
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6804/review/3986075793 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260321/750175b4/attachment.htm>
More information about the rails-dev
mailing list