[openstreetmap/openstreetmap-website] Adjust Bootstrap icon usage (PR #6501)

[Tom Hughes]

@tomhughes commented on this pull request.



> @@ -0,0 +1,5 @@
+<%# locals: () %>
+
+<div class="spinner-border" role="status">
+  <span class="visually-hidden"><%= t("browse.start_rjs.loading") %></span>

Should we move that string to the `shared` scope, or maybe create a duplicate of it there? Note that if we move it and the js still uses it then we need to make sure it's still exported.

> @@ -11,7 +11,7 @@ def linkify(text)
   end
 
   def rss_link_to(args = {})
-    link_to tag.i(:class => "bi bi-rss-fill fs-6", :aria => { :hidden => "true" }), args
+    link_to tag.i(:class => "bi bi-rss-fill fs-6 role-administrator", :aria => { :hidden => "true" }), args

I'm not sure I'm keen on abusing the `role-administrator` class like this just because it happens to be the same colour as the RSS icon...

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6501#pullrequestreview-3988491610
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6501/review/3988491610 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260322/e413e899/attachment.htm>