[openstreetmap/openstreetmap-website] Another libxml2 issue + strengthen negative assertions (PR #6927)

Pablo Brasero notifications at github.com
Mon Mar 23 13:48:09 UTC 2026


Follow-up to https://github.com/openstreetmap/openstreetmap-website/pull/6902, where I tweaked an assertion to work reliably on macOS, after what appears to be a change of behaviour in libxml2. At the time I missed another instance of the same issue, so that's it changed here.

Additionally, a separate commit refactors negative assertions in the same test, which is something I'm always wary of. That sort of assertion can pass accidentally all too easily, due to a typo or whatever. I try to avoid them, and if not at least base them on the same code as the counterpart positive assertion
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/6927

-- Commit Summary --

  * Work on macOS, following a change in libxml2
  * Strengthen negative assertions

-- File Changes --

    M test/jobs/trace_importer_job_test.rb (26)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/6927.patch
https://github.com/openstreetmap/openstreetmap-website/pull/6927.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6927
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6927 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260323/7a4920bc/attachment.htm>


More information about the rails-dev mailing list