[openstreetmap/openstreetmap-website] Configure queues for new notification system (PR #6929)
Tom Hughes
notifications at github.com
Mon Mar 23 22:03:29 UTC 2026
After further investigation of #6924 it appears that the situation is:
* The initial `Noticed::EventJob` is sent to the `default` queue and the only direct way to override that is with the `:queue` option on the call to `deliver` with no simple way to set a default.
* When delivering an email the event job will queue a `Noticed::DeliveryMethod::Email` job to the `default` queue unless the `queue` option is set by the `deliver_by` block for the event with no simple way to set a global default.
So what this does is to patch the job classes, based on the ideas in https://github.com/excid3/noticed/issues/294, https://github.com/excid3/noticed/discussions/324 and https://github.com/excid3/noticed?tab=readme-ov-file#custom-noticed-model-methods.
While doing this I also confirmed that using `deliver_later` on a notification is pointless as it's actually just an alias for `deliver` so I've changed that as well.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6929
-- Commit Summary --
* Configure queues for notifications
* Use deliver for notifications as deliver_later is an alias
-- File Changes --
M app/controllers/api/changeset_comments_controller.rb (2)
A config/initializers/noticed.rb (26)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/6929.patch
https://github.com/openstreetmap/openstreetmap-website/pull/6929.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6929
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6929 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260323/e434929a/attachment-0001.htm>
More information about the rails-dev
mailing list